[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation.
From: |
Filip Navara |
Subject: |
Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation. |
Date: |
Thu, 23 Jul 2009 22:28:52 +0200 |
On Thu, Jul 23, 2009 at 10:10 PM, Stuart Brady<address@hidden> wrote:
> + dest = args[0];
> + src = args[1];
> + if (const_temps[src]) {
> + const_temps[dest] = 1;
> + dest_val = ~temp_values[src];
> + *opc_ptr = INDEX_op_movi_i32;
>
> Hrm... is it really right to be setting *opc_ptr = INDEX_op_movi_i32
> even for 64-bit ops? Applies to both 'not'[0] and the binary ops...
You are right, another bug :) I wish I could test it on some 64-bit
target, but QEMU is not working on MinGW64 (unsigned long !=
intptr_t).
Thanks,
Filip Navara