[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MAC
From: |
Nathan Froyd |
Subject: |
Re: [Qemu-devel] [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MACHINE_BSWAP_H |
Date: |
Fri, 24 Jul 2009 13:46:28 -0700 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Fri, Jul 24, 2009 at 08:30:22PM +0200, Juan Quintela wrote:
> @@ -176,7 +176,7 @@
> VPATH+=:$(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
> CPPFLAGS+=-I$(SRC_PATH)/linux-user -I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>
> ifeq ($(ARCH),i386)
> -ifdef TARGET_GPROF
> +ifdef CONFIG_GPROF
> USE_I386_LD=y
> endif
> ifdef CONFIG_STATIC
I don't see anything obviously wrong with the rest of the patch, but
this hunk and others make it look like you forgot to split out a patch
in your patch series.
-Nathan
- [Qemu-devel] [PATCH 25/46] rename DEBUG_EXEC to CONFIG_DEBUG_EXEC, (continued)
- [Qemu-devel] [PATCH 25/46] rename DEBUG_EXEC to CONFIG_DEBUG_EXEC, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 26/46] rename WORDS_BIGENDIAN to CONFIG_WORDS_BIGENDIAN, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 27/46] Add CONFIG_POSIX, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 29/46] the else part of this test is obsolete We are testing for sdl = yes inside the else part of the test if sdl = yes, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 28/46] Use CONFIG_POSIX to simplify Makefile, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 30/46] sdl_config value was always sdl-config, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 31/46] Calculate sdl_libs and sdl_flags and use them everywhere, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MACHINE_BSWAP_H, Juan Quintela, 2009/07/24
- Re: [Qemu-devel] [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MACHINE_BSWAP_H,
Nathan Froyd <=
- [Qemu-devel] [PATCH 32/46] instead of setup sdl_x11 just add -lX11 to sdl_libs, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 34/46] remove sdl_static. Just do the right thing if static is yes, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 33/46] target_softmmu is undefined at that point, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 36/46] Define and use xen libs in a single place, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 35/46] indent with 2 spaces sdl tests, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 37/46] simplify curses library selection, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 38/46] simplify brlapi selection, Juan Quintela, 2009/07/24
- [Qemu-devel] [PATCH 39/46] simplify vde libs selection, Juan Quintela, 2009/07/24