[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define

From: Juan Quintela
Subject: [Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define
Date: Sun, 26 Jul 2009 15:41:49 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)

Anthony Liguori <address@hidden> wrote:
> malc wrote:
>> On Fri, 24 Jul 2009, Juan Quintela wrote:
>>> Signed-off-by: Juan Quintela <address@hidden>
>>> ---
>>>  audio/audio.c |   25 ++++++++++++++++++++++++-
>>>  configure     |    3 ---
>>>  2 files changed, 24 insertions(+), 4 deletions(-)
>> That's how it used to be before, i see no reason of going back to this
>> style.
> Right.  The way to get rid of AUDIO_DRIVERS is to convert drvtab[] to
> be a list with an appropriate audio driver registration function.
> Each .c file should have an audio_init() method that then registers
> the audio_driver structure.  Individual audio drivers can be
> added/removed by simply building or not building the file.
> Just like how the block infrastructure works.
> Regards,
> Anthony Liguori

Not enough. See malc hint (g show 0c58ac1c7)

The order in audio_drivers is important, that means you can have a
different default sound driver.

After some thinking, my current plan is exporting audio_drv_list
to the Makefile, and then generating something similar to AUDIO_DRIVERS.

Notice that the "ordering" problems not only happens with sound drivers,
we have the same problems with graphics console, which one is the
default one?  It depends on what you have configured, and changing the
default order is far from trivial.

Later, Juan.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]