[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/4] Use proper struct initializers and remove I
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro |
Date: |
Tue, 28 Jul 2009 19:13:00 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
malc <address@hidden> wrote:
> On Mon, 27 Jul 2009, Anthony Liguori wrote:
>
>> malc wrote:
>> > On Mon, 27 Jul 2009, Juan Quintela wrote:
>> >
>> > This patch is pointless.
>> >
>>
>> The INIT_FIELD() stuff is goofy. struct initializers are C99 so using
>> them conditionally on GNUC is incorrect. Also, if you can't rely on the
>> initializier, what's the point of even doing it at all since you cannot
>> change order.
>
> The reason for this goofyness is that the code was fed as is to MSVC
> (in VirtualBox), the patch looks like a change for the sake of a change.
MSVC don't support C99 initializers in 2009? Wow :)
I was trying to get everything else consistent.
Later, Juan.
- [Qemu-devel] [PATCH 0/4] Use C99 struct initializers in audio/*, Juan Quintela, 2009/07/27
- [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro, Juan Quintela, 2009/07/27
- Re: [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro, malc, 2009/07/27
- Re: [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro, Anthony Liguori, 2009/07/27
- [Qemu-devel] Re: [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro, Paolo Bonzini, 2009/07/27
- Re: [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro, Anthony Liguori, 2009/07/27
- Re: [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro, malc, 2009/07/28
- [Qemu-devel] Re: [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro,
Juan Quintela <=
- [Qemu-devel] Re: [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro, malc, 2009/07/28
[Qemu-devel] [PATCH 2/4] use C99 initializers for audio_pcm_ops, Juan Quintela, 2009/07/27
[Qemu-devel] [PATCH 3/4] Use C99 initializers for audio_option, Juan Quintela, 2009/07/27