[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 25/25] Introduce qemu-dict unit-tests
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 25/25] Introduce qemu-dict unit-tests |
Date: |
Tue, 28 Jul 2009 19:05:13 -0300 |
This suite contains tests to assure that qemu-dict API will
work as expected.
To execute it, you should build QEMU with check support enabled
and then run:
$ ./check-qdict
Signed-off-by: Luiz Capitulino <address@hidden>
---
Makefile | 1 +
check-qdict.c | 289 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
configure | 2 +-
3 files changed, 291 insertions(+), 1 deletions(-)
create mode 100644 check-qdict.c
diff --git a/Makefile b/Makefile
index e63f09d..e65b2c7 100644
--- a/Makefile
+++ b/Makefile
@@ -216,6 +216,7 @@ qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
ifdef CONFIG_CHECK
LIBS += $(CHECK_LIBS)
+check-qdict: check-qdict.o qemu-dict.o qemu-malloc.o
endif
clean:
diff --git a/check-qdict.c b/check-qdict.c
new file mode 100644
index 0000000..ae3c19a
--- /dev/null
+++ b/check-qdict.c
@@ -0,0 +1,289 @@
+/*
+ * qemu-dict unit-tests.
+ *
+ * Copyright (C) 2009 Red Hat Inc.
+ *
+ * Authors:
+ * Luiz Capitulino <address@hidden>
+ *
+ * Not really the best unit-testing example (and not developed in a
+ * test-driven way), but does the job.
+ */
+#include <stdio.h>
+#include <stdlib.h>
+#include <check.h>
+
+#include "qemu-dict.h"
+
+/*
+ * Basic API tests
+ */
+
+START_TEST(create_test)
+{
+ struct qemu_dict *qdict;
+
+ qdict = qemu_dict_create();
+ fail_unless(qdict != NULL, "qdict is NULL");
+ fail_unless(qemu_dict_size(qdict) == 0, "size is not 0");
+
+ free(qdict);
+}
+END_TEST
+
+START_TEST(destroy_simple_test)
+{
+ struct qemu_dict *qdict;
+
+ qdict = qemu_dict_create();
+ fail_unless(qdict != NULL, "qdict is NULL");
+
+ qemu_dict_destroy(qdict);
+ fail_unless(qemu_dict_size(qdict) == 0, "size is not 0");
+}
+END_TEST
+
+static struct qemu_dict *tests_dict = NULL;
+
+static void qdict_setup(void)
+{
+ tests_dict = qemu_dict_create();
+ fail_unless(tests_dict != NULL, "tests_dict is NULL");
+}
+
+static void qdict_teardown(void)
+{
+ qemu_dict_destroy(tests_dict);
+ tests_dict = NULL;
+}
+
+/* two tests in one, not good but... */
+START_TEST(insert_new_test)
+{
+ int *ret, value = 42;
+ const char *key = "test";
+
+ qemu_dict_add(tests_dict, key, &value);
+ fail_unless(qemu_dict_size(tests_dict) == 1);
+
+ ret = qemu_dict_get(tests_dict, key);
+ fail_unless(*ret == value);
+}
+END_TEST
+
+START_TEST(insert_existing_test)
+{
+ int *ret, value1, value2;
+ const char *key = "test";
+
+ value1 = 42;
+ qemu_dict_add(tests_dict, key, &value1);
+ fail_unless(qemu_dict_size(tests_dict) == 1);
+
+ value2 = 667;
+ qemu_dict_add(tests_dict, key, &value2);
+
+ ret = qemu_dict_get(tests_dict, key);
+ fail_unless(*ret == value1);
+}
+END_TEST
+
+START_TEST(exists_not_exists_test)
+{
+ fail_unless(qemu_dict_exists(tests_dict, "test") == 0);
+}
+END_TEST
+
+START_TEST(exists_exists_test)
+{
+ const char *key = "test";
+
+ qemu_dict_add(tests_dict, key, NULL);
+ fail_unless(qemu_dict_exists(tests_dict, key) == 1);
+}
+END_TEST
+
+START_TEST(get_not_exists_test)
+{
+ fail_unless(qemu_dict_get(tests_dict, "test") == NULL);
+}
+END_TEST
+
+START_TEST(del_exists_test)
+{
+ int value = 42;
+ const char *key = "test";
+
+ qemu_dict_add(tests_dict, key, &value);
+ fail_unless(qemu_dict_size(tests_dict) == 1);
+
+ qemu_dict_del(tests_dict, key);
+ fail_unless(qemu_dict_size(tests_dict) == 0);
+ fail_unless(qemu_dict_get(tests_dict, key) == NULL);
+}
+END_TEST
+
+START_TEST(del_not_exists_test)
+{
+ const char *key = "test";
+
+ qemu_dict_del(tests_dict, key);
+ fail_unless(qemu_dict_size(tests_dict) == 0);
+ fail_unless(qemu_dict_get(tests_dict, key) == NULL);
+}
+END_TEST
+
+static int test_walkf_keys;
+static void test_walkf(const char *key, void *value)
+{
+ test_walkf_keys++;
+}
+
+START_TEST(walk_through_test)
+{
+ int i;
+ const char *strings[] = { "walk", "through", "test",
+ "foo", "bar", "qemu", "KVM",
+ NULL };
+
+ for (i = 0; strings[i] != NULL; i++)
+ qemu_dict_add(tests_dict, strings[i], NULL);
+
+ qemu_dict_walk(tests_dict, test_walkf);
+ fail_unless(test_walkf_keys == i);
+
+}
+END_TEST
+
+/*
+ * Stress test-case
+ *
+ * This is a lot big for a unit-test, but there is no other place
+ * to have it.
+ */
+
+static void remove_dots(char *string)
+{
+ char *p = strchr(string, ':');
+ if (p)
+ *p = '\0';
+}
+
+static int read_chars(FILE *file, char *key, char *value)
+{
+ if (fscanf(file, "%s%s", key, value) == EOF)
+ return 1;
+ remove_dots(key);
+ return 0;
+}
+
+#define reset_file(file) fseek(file, 0L, SEEK_SET)
+
+START_TEST(qdict_stress_test)
+{
+ size_t i;
+ FILE *test_file;
+ struct qemu_dict *qdict;
+ char key[128], value[128];
+
+ test_file = fopen("qdict-test-data.txt", "r");
+ fail_unless(test_file != NULL);
+
+ // Create the dict
+ qdict = qemu_dict_create();
+ fail_unless(qdict != NULL);
+
+ // Add everything from the test file
+ for (i = 0;; i++) {
+ if (read_chars(test_file, key, value))
+ break;
+ qemu_dict_add(qdict, key, strdup(value));
+ }
+ fail_unless(qemu_dict_size(qdict) == i);
+
+ // Check if everything is really in there
+ reset_file(test_file);
+ for (;;) {
+ char *p;
+
+ if (read_chars(test_file, key, value))
+ break;
+
+ p = qemu_dict_get(qdict, key);
+ fail_unless(p != NULL);
+ fail_unless(strcmp(p, value) == 0);
+ }
+
+ // Delete everything
+ reset_file(test_file);
+ for (;;) {
+ char *p;
+
+ if (read_chars(test_file, key, value))
+ break;
+
+ p = qemu_dict_del(qdict, key);
+ fail_unless(p != NULL);
+ fail_unless(strcmp(p, value) == 0);
+ free(p);
+
+ p = qemu_dict_get(qdict, key);
+ fail_unless(p == NULL);
+ }
+
+ fail_unless(qemu_dict_size(qdict) == 0);
+ qemu_dict_destroy(qdict);
+}
+END_TEST
+
+static Suite *qdict_suite(void)
+{
+ Suite *s;
+ TCase *qdict_api_tcase;
+ TCase *qdict_api2_tcase;
+ TCase *qdict_stress_tcase;
+
+ s = suite_create("qemu-dict test-suite");
+
+ /* Very basic API test-case */
+ qdict_api_tcase = tcase_create("Basic API");
+ suite_add_tcase(s, qdict_api_tcase);
+ tcase_add_test(qdict_api_tcase, create_test);
+ tcase_add_test(qdict_api_tcase, destroy_simple_test);
+
+ /* The same as above, but with fixture */
+ qdict_api2_tcase = tcase_create("Basic API 2");
+ suite_add_tcase(s, qdict_api2_tcase);
+ tcase_add_checked_fixture(qdict_api2_tcase, qdict_setup, qdict_teardown);
+ tcase_add_test(qdict_api2_tcase, insert_new_test);
+ tcase_add_test(qdict_api2_tcase, insert_existing_test);
+ tcase_add_test(qdict_api2_tcase, exists_not_exists_test);
+ tcase_add_test(qdict_api2_tcase, exists_exists_test);
+ tcase_add_test(qdict_api2_tcase, get_not_exists_test);
+ tcase_add_test(qdict_api2_tcase, del_exists_test);
+ tcase_add_test(qdict_api2_tcase, del_not_exists_test);
+ tcase_add_test(qdict_api2_tcase, walk_through_test);
+
+ /* The Big one */
+ qdict_stress_tcase = tcase_create("Stress test");
+ suite_add_tcase(s, qdict_stress_tcase);
+ tcase_add_test(qdict_stress_tcase, qdict_stress_test);
+
+ return s;
+}
+
+int main(void)
+{
+ int nf;
+ Suite *s;
+ SRunner *sr;
+
+ s = qdict_suite();
+ sr = srunner_create(s);
+
+ srunner_run_all(sr, CK_NORMAL);
+ nf = srunner_ntests_failed(sr);
+ srunner_free(sr);
+
+ return (nf == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
+}
diff --git a/configure b/configure
index dc2cdd2..0a4d4a6 100755
--- a/configure
+++ b/configure
@@ -1765,7 +1765,7 @@ if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then
if [ "$linux" = "yes" ] ; then
tools="qemu-nbd\$(EXESUF) qemu-io\$(EXESUF) $tools"
if [ "$check" = "yes" ]; then
- tools="$tools"
+ tools="check-qdict $tools"
fi
fi
fi
--
1.6.4.rc3.12.gdf73a
- [Qemu-devel] [PATCH 16/25] monitor: Port handler_7 to use the dictionary, (continued)
- [Qemu-devel] [PATCH 16/25] monitor: Port handler_7 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 17/25] monitor: Drop handler_8 and handler_9 handling, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 18/25] monitor: Port handler_10 to use the dictionary, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 19/25] monitor: Split monitor_handle_command(), Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 20/25] monitor: Add a new index for str_allocated[], Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 21/25] monitor: Drop args[] from monitor_parse_command(), Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 22/25] monitor: Drop 'nb_args' from monitor_parse_command(), Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 23/25] Add check support, Luiz Capitulino, 2009/07/28
- [Qemu-devel] [PATCH 25/25] Introduce qemu-dict unit-tests,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 24/25] Introduce dictionary test data file, Luiz Capitulino, 2009/07/28