[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] bug report + fix: e1000.c in 0.10.5 does not properly e
Re: [Qemu-devel] bug report + fix: e1000.c in 0.10.5 does not properly emulate real hardware
Tue, 28 Jul 2009 15:21:12 -0700
Of all the gin joints in all the towns in all the world, Anthony Liguori had
to walk into mine and say:
> Bill Paul wrote:
> > Hi guys:
> > I submitted a patch for e1000.c a while ago, to fix issues with the ICS
> > and EERD registers not being emulated properly, which I discovered while
> > testing QEMU with VxWorks. I provided binary VxWorks images and a
> > bootable bootrom floppy that works with QEMU for testing, but so far I
> > haven't heard anything further on this issue. I looked at the git
> > repository, and it doesn't look like the patch I submitted has been
> > applied yet.
> > Does anyone have an update on this? Just checking to make sure the patch
> > doesn't fall through the cracks.
> I see you sent out a version with a Signed-off-by, but you didn't send
> it as a top-level patch.
> Please resend it as a top level patch (a new subject starting with
> [PATCH]) and that will get the ball rolling.
Let me make sure I understand correctly.
You must have my previous e-mail with the patch in front of you, with the
attached unified diff. Are you saying that rather than just taking that
unidiff, from the e-mail I already sent, you want me to send you exactly the
same file, only with a different subject line that starts with [PATCH]?
I'd like to point out that a) while this may be part of some standardized
project etiquette, I've yet to see these required steps clearly spelled out
anywhere, and b) why can't you just take the diff I already sent and
apply/test/molest/etc it now that you have it?
> Anthony Liguori
> > -Bill
-Bill Paul (510) 749-2329 | Senior Engineer, Master of Unix-Fu
address@hidden | Wind River Systems
"I put a dollar in a change machine. Nothing changed." - George Carlin