[Qemu-devel] Re: [PATCH 16/47] O_LARGEFILE is already set in qemu-common.h

[Juan Quintela]

"Todd T. Fries" <address@hidden> wrote:
> Stupid observation here, if you renamed 'HOST_BSD' to 'CONFIG_BSD'
> didn't you miss something below?
>
> Penned by Juan Quintela on 20090727 16:12.55, we have:
> | 
> | Signed-off-by: Juan Quintela <address@hidden>
> | ---
> |  configure |    1 -
> |  1 files changed, 0 insertions(+), 1 deletions(-)
> | 
> | diff --git a/configure b/configure
> | index 3c5fb6e..be00e28 100755
> | --- a/configure
> | +++ b/configure
> | @@ -1746,7 +1746,6 @@ fi
> | 
> |  # XXX: suppress that
> |  if [ "$bsd" = "yes" ] ; then
> | -  echo "#define O_LARGEFILE 0" >> $config_host_h
> |    echo "#define MAP_ANONYMOUS MAP_ANON" >> $config_host_h
> |    echo "#define HOST_BSD 1" >> $config_host_h
> |  fi
> | -- 
> | 1.6.2.5
> | 
> | 

It is done later in the series, I saw it as CONFIG_BSD in upstream.

Thanks, Juan.