|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS |
Date: | Thu, 30 Jul 2009 08:58:46 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
Just wanted to point out that this is wrong. -I and -D *are* CPPFLAGS.However, the real issue is that CFLAGS should be reserved for the user at make time (defaulting to something *constant* like -O2 -g or whatever else). Actually so should CPPFLAGS, but at least it is much less likely to be used, while "make CFLAGS=-g" is common during development and supported by almost every package I know of.
You can also call it QEMU_CPPFLAGS or QEMU_CFLAGS and we can be happy.You then have to add both $(QEMU_CPPFLAGS) and $(CFLAGS) to compilation commands in both configure and Make.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |