qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] QemuOpts: add -drive-set option


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 4/5] QemuOpts: add -drive-set option
Date: Thu, 30 Jul 2009 13:44:11 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Gerd Hoffmann wrote:
On 07/30/09 15:58, Anthony Liguori wrote:
Gerd Hoffmann wrote:
The typical use case will be file (no filename quoting issues), i.e.

-drive id=test,if=virtio
-drive-set test.file=/vmdisk/test-virtio.img

I'm not a big fan of this syntax because you still end up with not
putting a filename as a single argument.

You can take everything after '=' as-is though, so the parsing/quoting issues are gone nevertheless.

I don't think it extends very
well to other option types either like -net.

Problem with the "-drive.$id.$arg $value" syntax suggested by you is that the qemu option parser can handle fixed -option strings only.

Right, but that shouldn't stop us if we think it's the right syntax.

But in the very least, instead of a -drive-set, -net-set, etc., I would rather that we had a single -set command that was like:

-set drive.test.file=/vmdisk/test-virtio.img

Whereas this could map into a config file fragment. Our host config file could then look like:

drive.test.file = "/vmdisk/test-virtio.img"

or:

[drive.test]
file = "/vmdisk/test-virtio.img"

I don't really know the right syntax, but that's where we should be heading.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]