[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] Fix checksum writing in signboot.sh
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH] Fix checksum writing in signboot.sh |
Date: |
Sat, 1 Aug 2009 11:48:31 +0200 |
The printf command takes an octal value after \, so we have to convert
our decimal representation to octal first and then write it.
This unbreaks extboot signing. Multiboot wasn't affected yet because
the checksum was < 8.
Spotted and first patch by Glauber Costa <address@hidden>.
Printf idea by Paolo Bonzini <address@hidden>.
Signed-off-by: Alexander Graf <address@hidden>
CC: Glauber Costa <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Jan Ondrej <address@hidden>
---
pc-bios/optionrom/signrom.sh | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/pc-bios/optionrom/signrom.sh b/pc-bios/optionrom/signrom.sh
index 4322811..975b27d 100755
--- a/pc-bios/optionrom/signrom.sh
+++ b/pc-bios/optionrom/signrom.sh
@@ -39,7 +39,8 @@ done
sum=$(( $sum % 256 ))
sum=$(( 256 - $sum ))
+sum_octal=$( printf "%o" $sum )
# and write the output file
cp "$1" "$2"
-printf "\\$sum" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc 2>/dev/null
+printf "\\$sum_octal" | dd of="$2" bs=1 count=1 seek=$size conv=notrunc
2>/dev/null
--
1.6.0.2
- [Qemu-devel] [PATCH] Fix checksum writing in signboot.sh,
Alexander Graf <=
- [Qemu-devel] Re: [PATCH] Fix checksum writing in signboot.sh, Avi Kivity, 2009/08/02
- Re: [Qemu-devel] Re: [PATCH] Fix checksum writing in signboot.sh, Filip Navara, 2009/08/02
- Re: [Qemu-devel] Re: [PATCH] Fix checksum writing in signboot.sh, Avi Kivity, 2009/08/02
- Re: [Qemu-devel] Re: [PATCH] Fix checksum writing in signboot.sh, Alexander Graf, 2009/08/02
- Re: [Qemu-devel] Re: [PATCH] Fix checksum writing in signboot.sh, Avi Kivity, 2009/08/02
- [Qemu-devel] Re: Re: [PATCH] Fix checksum writing in signboot.sh, Sebastian Herbszt, 2009/08/02
- Re: [Qemu-devel] Re: [PATCH] Fix checksum writing in signboot.sh, Anthony Liguori, 2009/08/02
- Re: [Qemu-devel] Re: [PATCH] Fix checksum writing in signboot.sh, Paolo Bonzini, 2009/08/03
- Re: [Qemu-devel] Re: [PATCH] Fix checksum writing in signboot.sh, Avi Kivity, 2009/08/03