[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/5] Seabios qemu detect

From: Kevin O'Connor
Subject: [Qemu-devel] Re: [PATCH 0/5] Seabios qemu detect
Date: Tue, 4 Aug 2009 21:20:31 -0400
User-agent: Mutt/1.5.19 (2009-01-05)

On Mon, Aug 03, 2009 at 03:32:36PM +0200, Jes Sorensen wrote:
> Hi,
> Argh! Forgot to post this yesterday!
> Here is a series of patches for Seabios which introduces support for
> QEMU_CFG_EMULATOR and uses it to select the irq0verride flag and for
> runtime detection of whether or not Seabios is running on QEMU and
> KVM.

Thanks Jes.

Once the backend work is committed to qemu or kvm, I think we should
check this into SeaBIOS.

A couple of minor notes on style: can you make the global variables
use more prominent names (eg, "EmulatorVersion" instead of "emu_ver"),
can you abstract the test "(emu_ver & 0xff00) == EMU_QEMU" into a
function - as it isn't obvious what it does, and finally, can you move
the code you added to post() into qemu_cfg_port_probe() instead?

You asked about detecting coreboot automatically.  There are several
ways to do this, but probably the easiest is to take advantage of the
fact that coreboot uses a dedicated 32bit entry point.  See the
(poorly named) post32 function in romlayout.S.

Note though, the coreboot case may still need some compile-time
checks, because of the code size increase resulting from doing the
tests at runtime.

Thanks again,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]