Re: [Qemu-devel] [PATCH 05/14] Change cpu_phys mem callback to use [offset, size) bounds instead of [start, end).

[Anthony Liguori]

Zachary Amsden wrote:
> Signed-off-by: Zachary Amsden <address@hidden>
> ---
>  cpu-all.h        |    2 +-
>  exec.c           |    4 ++--
>  hw/cirrus_vga.c  |   11 ++++++-----
>  hw/framebuffer.c |    2 +-
>  hw/vga.c         |   12 ++++++------
>  hw/vga_int.h     |    2 +-
>  kvm-all.c        |    4 ++--
>  7 files changed, 19 insertions(+), 18 deletions(-)
>
> diff --git a/cpu-all.h b/cpu-all.h
> index 97a224d..43bbf18 100644
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -907,7 +907,7 @@ int cpu_physical_memory_set_dirty_tracking(int enable);
>  int cpu_physical_memory_get_dirty_tracking(void);
>  
>  int cpu_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
> -                                   target_phys_addr_t end_addr);
> +                                   ram_addr_t size);
>  
>  void dump_exec_info(FILE *f,
>                      int (*cpu_fprintf)(FILE *f, const char *fmt, ...));
> diff --git a/exec.c b/exec.c
> index 688f603..f8bfcd4 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1921,12 +1921,12 @@ int cpu_physical_memory_get_dirty_tracking(void)
>  }
>  
>  int cpu_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
> -                                   target_phys_addr_t end_addr)
> +                                   ram_addr_t size)
>   

This breaks the build for i386-softmmu as ram_addr_t is a uint32_t 
there.  In vl.c, there's

static int ram_save_live(QEMUFile *f, int stage, void *opaque)
{
   ram_addr_t addr;
   uint64_t bytes_transferred_last;
   double bwidth = 0;
   uint64_t expected_time = 0;

   if (cpu_physical_sync_dirty_bitmap(0, TARGET_PHYS_ADDR_MAX) != 0) {

And you get a large integer truncation error.

Regards,

Anthony Liguori