[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] save/restore broken?

From: Anthony Liguori
Subject: Re: [Qemu-devel] save/restore broken?
Date: Thu, 13 Aug 2009 13:59:52 -0500
User-agent: Thunderbird (X11/20090320)

Luiz Capitulino wrote:
On Tue, 11 Aug 2009 18:39:47 +0200
Paolo Bonzini <address@hidden> wrote:

Hi all,

if I try to save and restore an image using current qemu and current libvirt, the load fails.

 Yes, it's broken. I'm unable to loadvm and to migrate.

 According to git bisect the problem was introduced by:
This should fix it.


Anthony Liguori
commit a536948b3805a311f274b119c5202fdc86504cf3
Author: Anthony Liguori <address@hidden>
Date:   Thu Aug 13 13:58:21 2009 -0500

    Fix migration for ide devices
    commit 93c8cfd9e67a62711b86f4c93747566885eb7928
    Author: Gleb Natapov <address@hidden>
    Date:   Sun Aug 2 11:36:47 2009 +0300
        make windows notice media change
    Broke save/restore by loading a new field but not saving it.
    Signed-off-by: Anthony Liguori <address@hidden>

diff --git a/hw/ide.c b/hw/ide.c
index bebda7c..1e38ae3 100644
--- a/hw/ide.c
+++ b/hw/ide.c
@@ -2888,6 +2888,7 @@ static void ide_save(QEMUFile* f, IDEState *s)
     qemu_put_8s(f, &s->sense_key);
     qemu_put_8s(f, &s->asc);
+    qemu_put_8s(f, &s->cdrom_changed);
     /* XXX: if a transfer is pending, we do not save it yet */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]