[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Implement RCC2 in Stellaris
From: |
Vijay Kumar |
Subject: |
Re: [Qemu-devel] [PATCH] Implement RCC2 in Stellaris |
Date: |
Sat, 15 Aug 2009 11:54:45 +0530 |
User-agent: |
Icedove 1.5.0.12 (X11/20070607) |
Krumme, Chris wrote:
>> ssys_state *s = (ssys_state *)opaque;
>>
>> - if (version_id != 1)
>> + if (version_id != 2)
>> return -EINVAL;
>>
>> s->pborctl = qemu_get_be32(f);
>> @@ -638,6 +703,7 @@ static int ssys_load(QEMUFile *f, void
>> *opaque, int version_id)
>> s->int_status = qemu_get_be32(f);
>> s->resc = qemu_get_be32(f);
>> s->rcc = qemu_get_be32(f);
>> + s->rcc2 = qemu_get_be32(f);
>
> If I understand correctly this should be protected by an if (version ==
> 2), and the if above should support both 1 and 2.
>
> This does not seem like a change that should break old --> new
> migration.
Thanks for the suggestion Chris. I will incorporate this and
send the updated patch.
Regards,
Vijay