Re: [Qemu-devel] [PATCH 0/3] New VMState table based load/save infrastructure

[Gerd Hoffmann]

  Hi,

> - For structures, Kraxel suggested to use a VMSTATE_INCLUDE() instead of
>    having to declare a new VMStateInfo struct.  As I already have the new
>    struct code working, I sent it with the struct.  Thinking about how to
>    implement the VMSTATE_INCLUDE() and which one is easier to use.

Looked at your code and figured the two approaches are not that 
different.  I'd just put the pointer to the chained/included 
VMStateDescription directly into the VMStateField to avoid the (IMHO 
pointless) indirection via VMStateInfo.

Also:  It would probably useful to have two include modes here:  One for 
embedded structs, i.e. this:

struct dev_state {
  PCIDevice dev;
};

... and one for referenced structs, i.e. this:

struct dev2_state {
  PCIDevice *dev;
};

cheers,
  Gerd