qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 00/29] QMonitor


From: Mark McLoughlin
Subject: Re: [Qemu-devel] [PATCH v3 00/29] QMonitor
Date: Thu, 03 Sep 2009 22:06:52 +0100

On Fri, 2009-08-28 at 15:27 -0300, Luiz Capitulino wrote:
>  Basically, this series introduces high-level data types (QInt, QString,
> QDict) and port all Monitor command handlers to use them to receive
> arguments.

Very nice, carefully prepared series. Well done.

It all looks good to me. I even went through each of the command
conversions to verify that the parameter names in the implementation
matched the names in the format and that optional parameters are handled
correctly etc. I couldn't spot a single issue.

Acked-by: Mark McLoughlin <address@hidden>

Cheers,
Mark.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]