Re: [Qemu-devel] [PATCH] virtio-console: Have a static instance of virtconsole

[Blue Swirl]

On Fri, Sep 4, 2009 at 7:40 PM, Amit Shah<address@hidden> wrote:
> On (Fri) Sep 04 2009 [19:37:25], Blue Swirl wrote:
>> On Fri, Sep 4, 2009 at 7:33 PM, Amit Shah<address@hidden> wrote:
>> > On (Fri) Sep 04 2009 [19:26:27], Blue Swirl wrote:
>> >> On Fri, Sep 4, 2009 at 12:14 PM, Amit Shah<address@hidden> wrote:
>> >> > Currently the VirtIOConsole struct is allocated from the call
>> >> > to virtio_common_init, also doing an UP_CAST implicitly.
>> >> >
>> >> > The new multiport functionality will need a few arrays and
>> >> > it's easier to move to the new VMState infrastructure by
>> >> > keeping it all within one struct.
>> >>
>> >> > +VirtIOConsole virtconsole;
>> >>
>> >> IMHO this is going to wrong direction. What kind of code would need a
>> >> static instance?
>> >
>> > Adding multiple ports to the console device, we'll have to store an
>> > array of ports here as well as config space. Both of these are
>> > device-specific.
>>
>> There could be a master device which managed all ports.
>
> There's only one instance of a virtio device created, and this device
> hosts multiple ports. And VirIOConsole is the master structure.

But instead of this, you should have a separate structure for the
master one, if that way you can avoid the static instance.