[Qemu-devel] Re: [PATCH 03/26] Remove SaveVM v2 support

[Stefano Stabellini]

On Thu, 10 Sep 2009, Juan Quintela wrote:
> Stefano Stabellini <address@hidden> wrote:
> > On Thu, 10 Sep 2009, Juan Quintela wrote:
> >> In previosu series I remove v2 support for RAM (that was the version that 
> >> was
> >> supported when SaveVM v3 appeared).  Now we can't load RAM for any image 
> >> saved in SaveVM v2, we can as well remove SaveVM v2 entirely.
> >> 
> >> Note: That SaveVM RAM was at v2 when General SaveVM support went from v2 
> >> to v3 makes talking about versions confusing at least
> >> 
> >
> > Please do not commit this patch, we are using the loadvm v2 code
> > actively, we should fix the v2 loading functions instead.
> > If no one else is going to do it, I'll fix it.
> 
> Details please.
> 
> What parts do you need?  all of it? part of it?  Notice that you can
> only be using it for loading state, writing state is done in V3.  We are
> moving towards V4 (still nothing done), will like to know what are your
> use case.
> 

First of all sorry if I come late into the discussion but I was on
vacation.

We just need the loading function and we don't even need the ram loading
portion of it but just the device state loading. Of course for qemu
doesn't make sense to keep only the device loading function around
therefore I suggested to keep it all and fix it instead.

As I have mentioned before I think it is really important to provide
backward compatibility, and we do in xen and xenserver without too much
trouble.
I am willing to send patches to fix the device state loading functions,
and we might already have few fixes in qemu-xen.

I realize that my use case is off the tree so you have all the rights
not to be interested in it, nonetheless I hope you don't completely
discard it because it would make our life difficult.