Re: [Qemu-devel] [PATCH 00/20] VMState: port all i2c devices

[Juha.Riihimaki]

Hi,

On Sep 11, 2009, at 13:10, ext Juan Quintela wrote:

> - i2c->address now are uint8_t, my review of all uses is that they  
> are always
>  used as uint8_t (and that is the type that is passed on the  
> value).  If you know
>  i2c, please check.  Change 0002 looks big, but it is because as I was

I would propose that the address has more than 8 bits to be more  
future-proof. After all, the bus addressing has already been extended  
to 10 bits: see http://www.i2c-bus.org/addressing/10-bit-addressing/


Regards,
Juha