[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/19] Port -net none and -net nic to QemuOpts
|
From: |
Mark McLoughlin |
|
Subject: |
Re: [Qemu-devel] [PATCH 09/19] Port -net none and -net nic to QemuOpts |
|
Date: |
Fri, 11 Sep 2009 13:39:24 +0100 |
On Fri, 2009-09-11 at 09:57 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > +#define NET_COMMON_PARAMS_DESC \
>
> > + .name = "name", \
> > + .type = QEMU_OPT_STRING, \
> > + .help = "identifier for monitor commands", \
>
> QemuOpts has id= which IMHO should be used here instead for consistency
> reasons. I suspect we have to support name= as well for backward
> compatibility ...
Yes, libvirt uses name= already
Cheers,
Mark.
- [Qemu-devel] [PATCH 05/19] Make qemu_opts_parse() handle empty strings, (continued)
- [Qemu-devel] [PATCH 10/19] Port -net user to QemuOpts, Mark McLoughlin, 2009/09/10
- [Qemu-devel] [PATCH 09/19] Port -net none and -net nic to QemuOpts, Mark McLoughlin, 2009/09/10
- [Qemu-devel] [PATCH 16/19] Port host_net_add monitor command to QemuOpts, Mark McLoughlin, 2009/09/10
- [Qemu-devel] [PATCH 14/19] Port -net dump to QemuOpts, Mark McLoughlin, 2009/09/10
- [Qemu-devel] [PATCH 17/19] Port usb net to QemuOpts, Mark McLoughlin, 2009/09/10
- [Qemu-devel] [PATCH 15/19] Clean up legacy code in net_client_init(), Mark McLoughlin, 2009/09/10
- [Qemu-devel] [PATCH 13/19] Port -net vde to QemuOpts, Mark McLoughlin, 2009/09/10
- [Qemu-devel] [PATCH 19/19] Final net cleanup after conversion to QemuOpts, Mark McLoughlin, 2009/09/10
- Re: [Qemu-devel] [PATCH 00/19] Port -net to QemuOpts, Mark McLoughlin, 2009/09/18