[Qemu-devel] Re: [PATCH 1/2] qemu/qdev: type safety in reset handler

[Paolo Bonzini]

On 09/15/2009 10:42 PM, Michael S. Tsirkin wrote:
> On Tue, Sep 15, 2009 at 11:20:25PM +0300, Blue Swirl wrote:
> > On Tue, Sep 15, 2009 at 5:33 PM, Michael S. Tsirkin<address@hidden>  wrote:
> > > Add type safety to qdev reset handlers, by declaring them as
> > > DeviceState * rather than void *.
> >
> > The function seems a bit unnecessary,
>
> which function?
>
> > how about instead:
>
> instead of which one?
>
> > static void rtl8139_reset(struct DeviceState *d)
> > {
> >      RTL8139State *s = container_of(d, RTL8139State, dev.qdev);

He means not introducing pci_rtl8139_reset.

Paolo