[Qemu-devel] Re: optional feature

[Juan Quintela]

"Michael S. Tsirkin" <address@hidden> wrote:
> On Wed, Sep 16, 2009 at 02:14:32PM +0200, Juan Quintela wrote:
>> >> See below, we are changing the state to one table, and tables don't have
>> >> neither if's or whiles (we have a limited for that just walks arrays).
>> >
>> > Let's just bite the bullet and add support for if's?  It's not like it's
>> > hard to invent 'struct vmstate_condition' or some such.
>> 
>> I have to do it.  The problem is not adding an optional field, is adding
>> it conditionally on _what_, and that _what_ should also be ideally on 
>> vmstate.
>> 
>> Later, Juan.
>
> pci config is on vmstate already, I don't see a problem here.

vmstate don't understand pci config.  I want to manipulate images with
the informantion that you have given vmstate.  Sending another byte
meaning:

msix_enabled

and now depending on that value another field is ok with me.  You can
calculate msix_enable at pre_save time whenever way that you see fit.
What vmstate needs is a only to now if msix_enable is 0 or 1, how you
calculate it, VMState don't care.

Later, Juan.