[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH] fdc: fix MAX_FD probelm
From: |
TAKEDA, toshiya |
Subject: |
Re: [Qemu-devel] Re: [PATCH] fdc: fix MAX_FD probelm |
Date: |
Thu, 17 Sep 2009 00:59:05 +0900 |
Dear Juan,
>"TAKEDA, toshiya" <address@hidden> wrote:
>> Dear Juan and members,
>>
>>>address@hidden (武田 俊也) wrote:
[snip]
>>>> .pre_save = fdc_pre_save,
>>>> .post_load = fdc_post_load,
>>>> .fields = (VMStateField []) {
>>>> @@ -692,7 +694,7 @@ static const VMStateDescription vmstate_fdc = {
>>>> VMSTATE_UINT8(lock, fdctrl_t),
>>>> VMSTATE_UINT8(pwrd, fdctrl_t),
>>>> VMSTATE_UINT8_EQUAL(num_floppies, fdctrl_t),
>>>> - VMSTATE_STRUCT_ARRAY(drives, fdctrl_t, MAX_FD, 1,
>>>> + VMSTATE_STRUCT_ARRAY(drives, fdctrl_t, MAX_LOGICAL_FD, 1,
>>>
>>>Will send a patch with support for:
>>>
>>>VMSTATE_STRUCT_ARRAY(drives, fdctrl_t, num_floppies, 1, wmstate_fdrive,
>>>fdrive_t)
>>
>> Well, it seems that we cannot specify the variable to WMSTATE_STRUCT_ARRAY.
>
>> And I found the problem that,
>> if I defined fdctrl_t->drives as fdrive_t drives[MAX_LOGICAL_FD];
>> and specify MAX_FD as VMSTATE_STRUCT_ARRAY(drives, fdctrl_t, MAX_FD, ...)
>> it cause the build error on MinGW.
>> It seems that we need to specify the same constant value.
>
>I sent patch to support it. Current code is to send whole arrays (and
>it complains if array size and what you send is not the same).
>
>This are the hearders of the mail that gets its support (not tested)
>
>From: Juan Quintela <address@hidden>
>Subject: [PATCH 4/4] vmstate: Add support for sending partial arrays
>To: address@hidden
>Date: Mon, 14 Sep 2009 22:15:21 +0200
>
>
>Later, Juan.
Oh, thank you very much !
I will wait that your patch is committed in git repository.