[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of silen
Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of silently exiting
Thu, 24 Sep 2009 19:01:44 +0530
On (Thu) Sep 24 2009 [15:30:27], Markus Armbruster wrote:
> Amit Shah <address@hidden> writes:
> > Hey Markus,
> > On (Wed) Sep 23 2009 [22:53:27], Markus Armbruster wrote:
> >> Amit Shah <address@hidden> writes:
> >> > If initializing a device fails, show the name of the device
> >> > and then exit
> >> "and then exit" is misleading, as you don't add an exit.
> > The 'return NULL' does that -- the calling function exits.
> > (doesn't the subject line clarify that?)
> You could say "show the name of the device before exiting".
That's what the subject says! :-)
> The message as you worded it made me look for an exit where there wasn't
> one before.
I'll respin it nevertheless.