Re: [Qemu-devel] [PATCH 12/13] pci: move unregister from PCIDevice to PCIDeviceInfo

[Gerd Hoffmann]

  Hi,

> >   static int pci_unregister_device(DeviceState *dev)

> > +    msix_uninit(pci_dev);

> Since devices call msix_add, I think it is cleaner to have them
> uninit it as well in their exit routines.

Would work too.  But this way you can't miss the msix_uninit() call by 
accident.  It also saves a few lines of code.  msix_uninit() carefully 
checks whenever msix is actually enabled and it is slow path, so calling 
it on non-msix devices isn't a big deal IMHO.

cheers,
  Gerd