[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 0/3] qdev-ify network cards
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RfC PATCH 0/3] qdev-ify network cards |
Date: |
Tue, 29 Sep 2009 00:50:09 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> Hi,
>
> Short RfC patch series to get the discussion rolling. We really need to
> get the nic drivers qdev-ified properly, so qemu stops segfaulting on
> '-device $any_nic_here'.
>
> To keep things small simple I've started with the ne2k_isa. All the PCI
> nics share the initialization path and thus I can't simply pick a single
> one as example and convert it.
>
> The network card can now be created using ...
>
> -device ne2k_isa,mac=00:11:22:33:44:55,vlan=0,irq=3,id=foo
[...]
>
> The nic initialization code calls qemu_new_vlan_client() with the
> vlan specified using the vlan property. Likewise the device cleanup
> code should call qemu_del_vlan_client. You don't see that in the
> patches though as ISA devices are not hot-pluggable ;)
>
> struct NICInfo is not needed at all here. I hope we can kill it long-term.
That would be good.
> This patch series is also available here:
> http://git.et.redhat.com/?p=qemu-kraxel.git;a=shortlog;h=refs/heads/nic.v1
>
> You might find it useful to have a look at the qbus patches. Especially
> the hotplug patches which add device_add and device_del monitor
> commands. The patches are on the qemu-devel list too and also here:
> http://git.et.redhat.com/?p=qemu-kraxel.git;a=shortlog;h=refs/heads/qbus.v2
Patches look fine to me.