qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config breakage


From: Avi Kivity
Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config breakage
Date: Tue, 29 Sep 2009 11:16:20 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3

On 09/29/2009 10:54 AM, Michael S. Tsirkin wrote:
On Tue, Sep 29, 2009 at 09:22:53AM +0200, Avi Kivity wrote:
On 09/29/2009 08:58 AM, Michael S. Tsirkin wrote:
Using bar per feature we'll quickly run out of BARs.
We already use a BAR for MSI-X - let's add
ATA identity there?

Mixing unrelated features will quickly cause confusion.
Note if we ever switch to 64 bit BARs, we'll only have 3 of these
available, so the ID would be using the last free one.
We can just as well plan ahead for when we'll add another feature?

I agree fixed offsets are messy though.  I previously proposed storing
the offset to the identity data in an i/o register. This will let each
implementation lay out this data in an optimal manner, without
confusion.

Yes, that works much better.

--
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]