[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config breakage

From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config breakage
Date: Tue, 29 Sep 2009 21:17:00 -0500
User-agent: Thunderbird (X11/20090825)

Rusty Russell wrote:
On Wed, 30 Sep 2009 06:25:39 am Anthony Liguori wrote:
virtio-blk isn't an ATA device so why pretend like it is?

Do you want to maintain a "vdparm" to match hdparm and sdparm?

That's an argument to implement the HDIO_GET_IDENTITY ioctl in the Linux virtio-blk driver. That's a totally reasonable thing to do.

However, baking something into the virtio-blk ABI because Linux requires an hdparm, sdparm, and potentially a vdparm doesn't seem like a good idea to me. We should expose the information that makes sense for a virtio block device and if a guest wants to create an ATA identify response out of that data, more power to it.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]