[Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix)

[Michael S. Tsirkin]

On Wed, Sep 30, 2009 at 07:31:36PM +0200, Paolo Bonzini wrote:
>
>>> We could also select a new style, like Linux kernel one. I'm also not
>>> a great fan of that either. But at least 'indent' could be used very
>>> easily and I think there would be other benefits, like reuse of Git
>>> hooks, patch checking scripts and Emacs configs. With full 'indent'
>>> support all sources could be massaged mechanically to make the switch
>>> less painful.
>>>
>>> Then there are K&R and GNU styles, but I like them even less.
>>
>> So ... Linux kernel style wins? What do others think?
>
> Linux kernel with 4-char indent?  That would avoid the need to run  
> indent

That loses the benefit of automatic style checkers/formatters
developed for kernel.

> (indent requires knowledge of all the names of the types, so a  
> mechanical pass through the sources is more easily said than done).
>
> Paolo

vim does a decent job typically.


-- 
MST