Re: [Qemu-devel] [PATCH 4/9] pci: use uint64_t for bar addr and size instead of uint32_t.

[malc]

On Thu, 1 Oct 2009, Michael S. Tsirkin wrote:

> On Wed, Sep 30, 2009 at 09:59:11PM +0400, malc wrote:
> > On Wed, 30 Sep 2009, Michael S. Tsirkin wrote:
> > 

[..snip..]

> > > > 
> > > > _t suffix is reserved by POSIX.
> > > 
> > > There's still no better naming for scalars.  Worst case some platform
> > > will fail to compile, and we'll rename.
> > > 
> > 
> > Not good enough, if you are using something you have to abide the
> > constraints.
> 
> So, posix does not reserve all of *_t namespace, it would negate years
> of C code. It simply says posix implementations can add only symbols
> ending with _t in the headers: this is a constraint on posix headers,
> not on applications that use them.  Thus you have to find some other
> means to avoid conflict if you have symbols ending with _t. Using your
> module name as a prefix is a classical way to do this, for pci prefixing
> type name with pci_ should be enough to prevent any issues.

I don't understand this at all. POSIX says that if you include any of
it's headers be prepared to deal with it, i.e. any of your own
typedefs that end with _t are potentially clashing with what's defined
there, similarly identifiers that start with 'str', 'E', double
underscore and underscore followed by a capital letter are reserved by
C, you just don't go there.

-- 
mailto:address@hidden