[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] linux-user: don't zero a buffer twice
From: |
Paul Bolle |
Subject: |
[Qemu-devel] [PATCH] linux-user: don't zero a buffer twice |
Date: |
Fri, 02 Oct 2009 14:10:04 +0200 |
prepare_binprm() zeroes bprm->buf. That buffer is already zeroed in
main() and hasn't been touched since so that is not necessary.
Signed-off-by: Paul Bolle <address@hidden>
---
Just a minor issue that I noticed while reading the code for some other reason.
bsd-user/bsdload.c could need a similar patch. I haven't looked at that yet.
linux-user/linuxload.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/linux-user/linuxload.c b/linux-user/linuxload.c
index 4091bdc..2d778a2 100644
--- a/linux-user/linuxload.c
+++ b/linux-user/linuxload.c
@@ -96,7 +96,6 @@ static int prepare_binprm(struct linux_binprm *bprm)
}
}
- memset(bprm->buf, 0, sizeof(bprm->buf));
retval = lseek(bprm->fd, 0L, SEEK_SET);
if(retval >= 0) {
retval = read(bprm->fd, bprm->buf, 128);
--
1.6.5.rc2
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH] linux-user: don't zero a buffer twice,
Paul Bolle <=