Re: [Qemu-devel] [PATCH] tcg, tci: Add TCG and interpreter for bytecode (virtual machine)

[Stuart Brady]

On Mon, Sep 28, 2009 at 06:50:21PM +0200, Stefan Weil wrote:
> Please send patches / enhancements based on my latest
> version from git://repo.or.cz/qemu/ar7.git.

Just bug reports for now, unfortunately...

exec-all.h defines 'USE_DIRECT_JUMP' based on the host architecture,
which is not relevant under TCI.  Also, a tb_set_jmp_target1()
implementation is needed for TCI.

I think tcg_out64() belongs in tcg.c along with tcg_out8/16/32().
There are places where the x86_64, ppc64 and s390 TCG targets call
out32() twice, which should be replaced with a single call to out64().

tcg_out16(), tcg_out32() and tcg_out64(), etc. rely on the code buffer
pointer being aligned on those architectures that require alignment...
We'd need definitions of these in terms of stw_p(), stl_p() and stq_p()
for TCI...  Is there any reason to preserve the old definitions?

(BTW, there's no 'ldul' macro, so perhaps one should be added, although
the names in that set of macros and functions are rather unclear, so
perhaps some more descriptive naming could be used for new code.)

Cheers,
-- 
Stuart Brady