[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] qemu/pci: clarify pci config load routine
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH] qemu/pci: clarify pci config load routine |
Date: |
Tue, 06 Oct 2009 00:47:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> wrote:
> PCI load routine has to be called with size equal to 256 (otherwise it
> will crash in weird ways). So assert this,
Agreed with the assert().
> making code clearer.
> Also avoid dynamically sized array on stack - good for portability.
size has the right value, namely sizeof(PCIDevice.config). Only real
advantage is that you are not using a dynamically sized array on the
stack.
I don't care one way or another. And as you are more probable to touch
that code than me, it is up to you :)
Later, Juan.