[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 3/3] char: emit the OPENED event only when a new
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened |
Date: |
Wed, 7 Oct 2009 18:31:17 +0530 |
The OPENED event gets sent also when qemu resets its state initially.
The consumers of the event aren't interested in receiving this event
on reset.
Signed-off-by: Amit Shah <address@hidden>
---
qemu-char.c | 7 ++++++-
qemu-char.h | 2 ++
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 4757689..0fd402c 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -119,7 +119,12 @@ static void qemu_chr_event(CharDriverState *s, int event)
static void qemu_chr_reset_bh(void *opaque)
{
CharDriverState *s = opaque;
- qemu_chr_event(s, CHR_EVENT_OPENED);
+
+ if (s->initial_reset_issued) {
+ qemu_chr_event(s, CHR_EVENT_OPENED);
+ } else {
+ s->initial_reset_issued = true;
+ }
qemu_bh_delete(s->bh);
s->bh = NULL;
}
diff --git a/qemu-char.h b/qemu-char.h
index 05fe15d..409961d 100644
--- a/qemu-char.h
+++ b/qemu-char.h
@@ -1,6 +1,7 @@
#ifndef QEMU_CHAR_H
#define QEMU_CHAR_H
+#include <stdbool.h>
#include "qemu-common.h"
#include "qemu-queue.h"
#include "qemu-option.h"
@@ -66,6 +67,7 @@ struct CharDriverState {
QEMUBH *bh;
char *label;
char *filename;
+ bool initial_reset_issued;
QTAILQ_ENTRY(CharDriverState) next;
};
--
1.6.2.5
- [Qemu-devel] [PATCH v2 0/3] Send out OPENED events only on chardev open, Amit Shah, 2009/10/07
- [Qemu-devel] [PATCH v2 1/3] char: check for initial_reset_issued unnecessary, Amit Shah, 2009/10/07
- [Qemu-devel] [PATCH v2 2/3] char: rename CHR_EVENT_RESET to CHR_EVENT_OPENED, Amit Shah, 2009/10/07
- [Qemu-devel] [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened,
Amit Shah <=
- [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Jan Kiszka, 2009/10/24
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/25
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Jan Kiszka, 2009/10/26
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/26
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Jan Kiszka, 2009/10/26
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Kevin Wolf, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Anthony Liguori, 2009/10/27
- Re: [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened, Amit Shah, 2009/10/27