[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] eepro100: Remove unused device status entries
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] eepro100: Remove unused device status entries |
Date: |
Thu, 08 Oct 2009 21:19:04 +0200 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090707) |
Stuart Brady schrieb:
> On Thu, Oct 08, 2009 at 08:15:37AM +0200, Stefan Weil wrote:
>
> [snip entertaining patch description]
>
>
>> - if (version_id >= 2) {
>> - qemu_get_8s(f, &s->rxcr);
>> - } else {
>> - s->rxcr = 0x0c;
>> - }
>> + /* Skip unused entries. */
>> + qemu_fseek(f, 32, SEEK_CUR);
>>
>
> Shouldn't the number of bytes skipped depend on the version ID?
>
> Cheers,
>
There was never a version id other than 3, so the "else" was junk.
The old code was a copy from ne2000.c, my original contribution
had marked it as work in progress.
Regards
Stefan