Re: [Qemu-devel] Re: [PATCH] Revert "posix-aio-compat: avoid signal race when spawning a thread"

[malc]

On Fri, 9 Oct 2009, Jamie Lokier wrote:

> malc wrote:
> > On Thu, 8 Oct 2009, Jamie Lokier wrote:
> > 
> > > malc wrote:
> > > > On Thu, 8 Oct 2009, Jamie Lokier wrote:
> > > > 
> > > > > malc wrote:
> > > > > > >   The  use of sigprocmask() is unspecified in a
> > > > > > >   multithreaded process; see pthread_sigmask(3).
> > > > > > > 
> > > > > > > Does it matter?
> > > > > > 
> > > > > > One of the patches i've asked you to try today replaced sigprocmask 
> > > > > > with
> > > > > > pthread_sigmask, you've said it did nothing. In any case, strictly
> > > > > > speaking, the code is wrong, so yes it does matter in theory.
> > > > > 
> > > > > It won't matter on a Linux host (they are the same), but
> > > > > pthread_sigmask should be used because it's Right(tm) and it could
> > > > > make a difference on some other host.
> > > > 
> > > > What made you think i'm of a different opinion?
> > > 
> > > The fact you asked Michael to test a patch which replaced sigprocmask
> > > with pthread_sigmask.
> > 
> > That made you think i'm somehow in favour of sigprocmask? I'm confused.
> 
> It didn't make me think you're in favour of sigprocmask.
> 
> It made me think you thought there was a difference between them that
> would affect the bug.
> 
> Anyways, I think we're done with this subthread :-)

Goooood :)

-- 
mailto:address@hidden