[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present |
Date: |
Thu, 15 Oct 2009 11:46:22 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote:
> As i8259 in mips_jazz.c is not connect to isa bus correctly, this
> patch fix that.
It looks fine. Could you please resend the patch with a Signed-off-by:
> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
> index 3ff367d..281713c 100644
> --- a/hw/mips_jazz.c
> +++ b/hw/mips_jazz.c
> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
>
> /* ISA devices */
> i8259 = i8259_init(env->irq[4]);
> + isa_bus_new(NULL);
> + isa_bus_irqs(i8259);
> DMA_init(0);
> pit = pit_init(0x40, i8259[0]);
> pcspk_init(pit);
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net