[Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module

[Anthony Liguori]

Paolo Bonzini wrote:
> On 10/16/2009 03:45 PM, Anthony Liguori wrote:
> > Paolo Bonzini wrote:
> > > It's 36k, and pulling it in gives the opportunity to customize it. For
> > > example, the attached patch allows to parse a "%BLAH" extension to
> > > JSON that is passed to the callback (since the parsing is done
> > > character-by-character, the callback can consume whatever it wants
> > > after the % sign). Asprintf+parse JSON unfortunately isn't enough
> > > because you'd need to escape all strings.
> >
> > What's the state of this library's upstream? Should we be pushing these
> > changes there and then attempting to package it?
>
> There's no repository, there's no mention of it in the author's blog, 
> it has seen six changes in two years according to the file's heading.  
> The only reference on da Internet is at 
> http://tech.groups.yahoo.com/group/json/message/928.
>
> On the other hand, it's down to the point (it has no object model of 
> it's own), and it is fully asynchronous since it works 
> character-by-character which makes it easier to extend as in my patch 
> above.

Ugh!  I hate people trying to be clever.  The copyright is:

/*
Copyright (c) 2005 JSON.org

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to 
deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included 
in all
copies or substantial portions of the Software.

The Software shall be used for Good, not Evil.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS 
IN THE
SOFTWARE.
*/

"The Software shall be used for Good, not Evil." is added as part of the 
licensing text.  That screws up the otherwise X11 license and is highly 
unlikely to be GPL compatible.

We can't pull this into the tree or even link against it as a library.  
Try contacting the others and see about getting that silliness removed.

Regards,

Anthony Liguori