[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus,

From: Richard W.M. Jones
Subject: Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports
Date: Tue, 20 Oct 2009 12:08:06 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Tue, Oct 20, 2009 at 12:43:44PM +0530, Amit Shah wrote:
>  DEF("virtioconsole", HAS_ARG, QEMU_OPTION_virtiocon, \
>      "-virtioconsole c\n" \
> -    "                set virtio console\n")
> +    "                define virtio console\n")

It would be much better to add a detectable string here so we
(libguestfs) can tell if multiport is supported.  Something like:

       "                set virtio console (multiport)\n"

>  @item -virtioconsole @var{c}
>  Set virtio console.
> +
> +This option is maintained for backward compatibility.
> +
> +Please use @code{-device virtioconsole} for the new way of invocation

I think you mean -device virtconsole here.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw

reply via email to

[Prev in Thread] Current Thread [Next in Thread]