Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation

[Anthony Liguori]

Alexander Graf wrote:
> So you would prefer a special #ifdef for s390 in generic code over a 
> specifically for this purpose exported function?
>
> Well, you're the boss. I like the special function better, but 
> whatever you say.

How is someone supposed to figure out what _qemu_ram_alloc is for?  
Nothing in your patch really indicates that.

However, an ugly #ifdef immediately tells someone, oh, s390 kvm needs 
this terrible hack, so let's keep bugging those guys to eliminate the 
need for that.

Regards,

Anthony Liguori

> Alex