Re: [Qemu-devel] [PATCH] Configurable block format whitelist

[malc]

On Tue, 27 Oct 2009, Markus Armbruster wrote:

> We have code for a quite a few block formats.  While I trust that all
> of these formats are useful at least for some people in some
> circumstances, some of them are of a kind that friends don't let
> friends use in production.
> 
> This patch provides an optional block format whitelist, default off.
> If a whitelist is configured with --block-drv-whitelist, QEMU proper
> can use only whitelisted formats.  Other programs, like qemu-img, are
> not affected.
> 
> Drivers for formats off the whitelist still participate in format
> probing, to ensure all programs probe exactly the same.  Without that,
> QEMU proper would be prone to treat images with a format off the
> whitelist as raw when the image's format is probed.
> 

[..snip..]

> diff --git a/create_config b/create_config
> index 30d0487..2f052ae 100755
> --- a/create_config
> +++ b/create_config
> @@ -26,6 +26,13 @@ case $line in
>      done
>      echo ""
>      ;;
> + CONFIG_BDRV_WHITELIST=*)
> +    echo "#define CONFIG_BDRV_WHITELIST \\"
> +    for drv in ${line#*=}; do
> +      echo "    \"${drv}\",\\"

printf ' "%s", \' ${drv}
feels less obfuscated

[..snip..]

-- 
mailto:address@hidden