Re: [Qemu-devel] [PATCH] target-arm: tcg temp variable usage cleanup

[Juha.Riihimaki]

On Nov 1, 2009, at 02:08, ext Laurent Desnogues wrote:

> On Thu, Oct 29, 2009 at 3:01 PM,  <address@hidden> wrote:
>> From: Juha Riihimäki <address@hidden>
>>
>> TCG temporary variable handling in target-arm/translate.c is  
>> currently
>> somewhat inconsistent; some functions allocate new temporaries that  
>> the
>> calling function is expected to free and some other functions free
>> temporaries that are passed in as parameters. This patch will  
>> remove all
>> such instances in the code and make the lifespan of the temporaries  
>> more
>> clearly visible as they are always allocated and freed within one  
>> function.
>> The only exception to this are the global temporaries allocated in  
>> the
>> beginning of the gen_intermediate_code_internal function.
[...]
> I tested your patch by running translate + TCG code gen
> for all of the opcodes in the range e0000000-ffffffff.
> For the NEON instructions I had to add correct undefined
> detection to let my program process the range (OTOH I
> didn't bother fixing the wrong decoding and/or codegen,
> I was just doing sanity check on your patch).
>
> Next step is to also do that for Thumb2.  And then run
> some real programs.

Thanks for your work so far. I fixed the things you pointed out, but  
I'll hold submitting a new version of the patch until you have had  
time to do more testing. I tested with the n810 system emulation, it  
was working fine.


Regards,
Juha