Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu initialization

[Blue Swirl]

On Sat, Nov 7, 2009 at 6:02 PM, Laurent Desnogues
<address@hidden> wrote:
> On Sat, Nov 7, 2009 at 9:40 AM, Blue Swirl <address@hidden> wrote:
> [...]
>> Thanks, applied. While testing I noticed that the poor x86 emulator
>> does not survive even five system_resets until BIOS refuses to boot.
>> This happens without your patch. In comparison, I see no problems
>> resetting Sparc32, Sparc64 or PPC.
>
> Unless I missed something you didn't commit Glauber's patch.

What's c169998802505c244b8bcad562633f29de7d74a4 then?

> So now in user mode cpu_reset differs for i386, SPARC
> and PPC, and all other targets.

No, for example MIPS cpu_reset is still called only once from cpu_mips_init.

> On top of that you didn't add a call to cpu_reset from cpu_copy
> which also calls cpu_init.  Are you sure it's OK?

It's not, I forgot to add that, sorry.