[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 04/20] pci: remove pci_addr_to_config() by open
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 04/20] pci: remove pci_addr_to_config() by open code |
Date: |
Thu, 12 Nov 2009 13:01:36 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Thu, Nov 12, 2009 at 02:58:32PM +0900, Isaku Yamahata wrote:
> This patch removes pci_addr_to_config() and open code it
> as suggested by Michael S. Tsirkin <address@hidden>.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/pci_host.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/hw/pci_host.c b/hw/pci_host.c
> index 4196ebc..93c94e8 100644
> --- a/hw/pci_host.c
> +++ b/hw/pci_host.c
> @@ -47,15 +47,10 @@ static inline PCIDevice *pci_addr_to_dev(PCIBus *bus,
> uint32_t addr)
> return pci_find_device(bus, bus_num, PCI_SLOT(devfn), PCI_FUNC(devfn));
> }
>
> -static inline uint32_t pci_addr_to_config(uint32_t addr)
> -{
> - return addr & (PCI_CONFIG_SPACE_SIZE - 1);
> -}
> -
> void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val, int len)
> {
> PCIDevice *pci_dev = pci_addr_to_dev(s, addr);
> - uint32_t config_addr = pci_addr_to_config(addr);
> + uint32_t config_addr = addr & (PCI_CONFIG_SPACE_SIZE - 1);
>
> if (!pci_dev)
> return;
> @@ -68,7 +63,7 @@ void pci_data_write(PCIBus *s, uint32_t addr, uint32_t val,
> int len)
> uint32_t pci_data_read(PCIBus *s, uint32_t addr, int len)
> {
> PCIDevice *pci_dev = pci_addr_to_dev(s, addr);
> - uint32_t config_addr = pci_addr_to_config(addr);
> + uint32_t config_addr = addr & (PCI_CONFIG_SPACE_SIZE - 1);
> uint32_t val;
>
> assert(len == 1 || len == 2 || len == 4);
> --
> 1.6.0.2
- [Qemu-devel] [PATCH 13/20] pci: move typedef, PCIHostState, PCIExpressHost to qemu-common.h., (continued)
- [Qemu-devel] [PATCH 13/20] pci: move typedef, PCIHostState, PCIExpressHost to qemu-common.h., Isaku Yamahata, 2009/11/12
- [Qemu-devel] [PATCH 20/20] pci: remove goto in pci_bridge_filter()., Isaku Yamahata, 2009/11/12
- [Qemu-devel] [PATCH 17/20] pci: remove magic number, 256 in pci.c, Isaku Yamahata, 2009/11/12
- [Qemu-devel] [PATCH 10/20] pci: kill unnecessary included in pci.c, Isaku Yamahata, 2009/11/12
- [Qemu-devel] [PATCH 04/20] pci: remove pci_addr_to_config() by open code, Isaku Yamahata, 2009/11/12
- [Qemu-devel] Re: [PATCH 04/20] pci: remove pci_addr_to_config() by open code,
Michael S. Tsirkin <=
- [Qemu-devel] Re: [PATCH 00/20] PCI express clean up patches., Michael S. Tsirkin, 2009/11/12