[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/15] scsi: add scsi-defs.h
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 07/15] scsi: add scsi-defs.h |
Date: |
Tue, 17 Nov 2009 12:35:41 +0100 |
User-agent: |
Mutt/1.3.28i |
On Tue, Nov 17, 2009 at 11:17:43AM +0100, Gerd Hoffmann wrote:
> Largely based on <scsi/scsi.h> from linux. Added into the tree so we
> can use the defines everywhere, not just in scsi-generic.c (which is
> linux-specific).
Btw, I'm not sure having the name clash with the Linux header is a good
idea as we need to include it for ioctls. Also the complete lack of
prefixes for the defines might causes some problems.
Otherwise a good idea,
Reviewed-by: Christoph Hellwig <address@hidden>
> @@ -0,0 +1,156 @@
> +/* Copyright (C) 1998, 1999 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
You probably want to take the kernel scsi.h to base things upon as it's
a lot more uptodate than the glibc one.
- Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code., (continued)
[Qemu-devel] [PATCH 10/15] scsi: use command defines in scsi-disk.c, Gerd Hoffmann, 2009/11/17
[Qemu-devel] [PATCH 14/15] scsi: move status to SCSIRequest., Gerd Hoffmann, 2009/11/17
[Qemu-devel] [PATCH 15/15] scsi: add scsi_req_print(), Gerd Hoffmann, 2009/11/17
[Qemu-devel] [PATCH 07/15] scsi: add scsi-defs.h, Gerd Hoffmann, 2009/11/17
- Re: [Qemu-devel] [PATCH 07/15] scsi: add scsi-defs.h,
Christoph Hellwig <=
[Qemu-devel] [PATCH 13/15] scsi: move dinfo to SCSIDevice, Gerd Hoffmann, 2009/11/17
[Qemu-devel] [PATCH 11/15] scsi: add xfer mode, Gerd Hoffmann, 2009/11/17
[Qemu-devel] Re: [PATCH 00/15] scsi: data structures and cleanups., Gerd Hoffmann, 2009/11/17