|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest. |
Date: | Tue, 17 Nov 2009 11:55:37 +0000 |
User-agent: | KMail/1.12.2 (Linux/2.6.30-2-amd64; KDE/4.3.2; x86_64; ; ) |
> move scsi command from SCSIGenericReq to SCSIRequest. Why? AFAICS This has precisely one user, and more importantly it is not populated by scsi-disk.c. Sharing common code is good. Implementing shared fields inconsistently or putting implementation specific fields in common structures. Paul
[Prev in Thread] | Current Thread | [Next in Thread] |