qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] OPT_SIZE parsing


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] OPT_SIZE parsing
Date: Tue, 17 Nov 2009 17:51:01 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 11/17/09 15:23, Ian Molton wrote:
I've cooked up this patch (attached) to add a SIZE property to qdevs.
I've kept the same semantics as the OPT_SIZE parser for now.

The error message should be adapted (s/Option/Property/ at least).

Maybe also create a common function for parsing called by both parse_size() and parse_option_size() to make sure OPT_SIZE and the new size property accept the same syntax?

Otherwise it looks fine to me.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]