[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 5/6] Convert linux bootrom to external rom a
Re: [Qemu-devel] Re: [PATCH 5/6] Convert linux bootrom to external rom and fw_cfg
Wed, 25 Nov 2009 11:38:01 +0100
On 13.11.2009, at 07:37, Paolo Bonzini wrote:
> On 11/12/2009 09:53 PM, Alexander Graf wrote:
>> + /* Set DS to SS+SP - 0x10, so we can write our GDT descriptor there */
>> + mov %ss, %eax
>> + shl $4, %eax
>> + add %esp, %eax
>> + sub $0x10, %eax
>> + shr $4, %eax
> Dead code? Or wrong comment and missing mov %eax, %gs?
> Also, I know this is running with disabled interrupts, but why set %gs just
> below the stack instead of decrementing %esp?
Uh. Decrementing %esp should work too I guess. That's just what I came up with.
[Qemu-devel] [PATCH 4/6] Move common option rom code to header file, Alexander Graf, 2009/11/12
[Qemu-devel] [PATCH 3/6] Convert multiboot to fw_cfg backed data storage, Alexander Graf, 2009/11/12
[Qemu-devel] [PATCH 1/6] Make fw_cfg interface 32-bit aware, Alexander Graf, 2009/11/12