|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [sneak preview] major scsi overhaul |
Date: | Thu, 26 Nov 2009 15:37:37 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 |
On 11/26/09 15:27, Hannes Reinecke wrote:
Gerd Hoffmann wrote:sd_done() tries to figure how many sectors it actually got for serious errors. I don't feel signaling "medium error" for the first sector behind our limit just because we'd like to have smaller requests.
scsi_end_request is being called with the number of bytes _actually processed_, which might be less than the number of bytes requested. And the remainder will be retried by the upper layers.
The "number of bytes _actually processed_" must come from somewhere. And that somewhere is sd_done() in case of scsi-disks. See my point now?
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |