[Qemu-devel] Re: [PATCHv2 1/3] pci: prepare irq code for interrupt state

[Juan Quintela]

"Michael S. Tsirkin" <address@hidden> wrote:
> This rearranges code in preparation for interrupt state
> implementation.
> Changes:
>       - split up but walk away from interrupt handling
>           into a subroutine
>       - change irq_state from an array to bitmask
>       - verify that irq_state values are 0 or 1 on load
>
> There are no functional changes.

I guess that there is a good reason for changing for an array of ints to
one bitmap.

Change looks ok, and if it worked for you, it should work for everybody
(if you breaks pci_device migration stops working).

I would delay changing things to bitmaps until we decide how to
implement bitmaps in qemu (there are more than one implementation), at
least:
   - use array of ints, save as array of ints (i.e. works between hosts with
     different endianess)
   - use arraf of ints but save as array of bytes (break when you change
     endianess)
   - Now, you have a bitmap that fits in an uint8_t.

An probably some other way that I have missed.

Later, Juan.